Assessment Wanted for Marking Up a Letter (NinditoWB)

MDN Learn
#1

Hello everyone, I’d love to have someone check if I have done my assessment correctly. Feedbacks on how to improve would be greatly appreciated. Thanks!

Link to Code: https://jsfiddle.net/Lsyt1n9p/1/
Link to Assessment Page: https://developer.mozilla.org/en-US/docs/Learn/HTML/Introduction_to_HTML/Marking_up_a_letter

#3

Hello @NinditoWB

you doing great well done and here are my notice :

  1. no need to wrap the address with div and not sure why you give it an id
  2. for the date of the first address it not part of address so keep it outside it and wrap this time element with p and give it the same class as the address (why the class does not work for time cause it inline element which you will learn later in css course)
  3. remove the div from second address also
  4. after the h1 element this Dear Eileen, is p element by it self
  5. Polynesian chicken dance is part of dl element so fix it with the other dances also do not use blockquote as you did
  6. remove all those div element

hope that help and have a nice day :slight_smile:

1 Like
#4

@justsomeone FYI That’s another old post that popped up because of a deleted message. :stuck_out_tongue:

1 Like
#5

i notice officer @mikoMK just did not want to make him/her stay alone :joy:

1 Like
#6

Your such a nice guy :smiley:
Never change! :+1:

1 Like
#7

oh thanks a lot office and you too :smile:

1 Like