Assessment wanted for -> Mozilla splash page

MDN Learn
,
#1

Here’s my GitHub repo. This was a really tough one, tons of new subjects to learn about. Any advice is always welcome!

#2

Hi @salvadorperezm

Cool thing that you are using GitHub :+1:
Could you please activate “GitHub Pages” for your repository: https://docs.github.com/en/pages/getting-started-with-github-pages/configuring-a-publishing-source-for-your-github-pages-site
This way your code will be published under https://salvadorperezm.github.io/MDN-Tutorials/html/Mozilla-Splash-Page-Assessment and we can see the running example.

Thank you very much :blush:
Michael

2 Likes
#3

Thank you! The assessment pointed out We could use GitHub so I went ahead and tried. Here’s the GitHub Pages link.

1 Like
#4

Thanks for the GitHub Pages link, @salvadorperezm!

You did a great job on this task. Everything works as intended. Congratulations! :+1:

I have just some small improvements:

  • A better fit for the logo in the header would be the smaller version (firefox-logo-120px.png)
  • When using relative paths you can omit ./ at the start. For example src="images/firefox-addons-400px.jpg" is fine.
  • You can omit the second <source> element inside the <picture> element. When the condition from the first <source> doesn’t match, it will automatically use the <img> element.

Keep up the good work :slightly_smiling_face:
Michael

1 Like
#5

Thank you!! I’ll update my code as soon as possible :smiley:.

1 Like
#6

Everything is fine now. Great job! :+1:

1 Like