Hey there!
May you assess my work?
https://github.com/Vovan1608/vovchik/tree/master/sixth-homework(CSS-school%20homepage)
Hi @zenya! I would be hppy to assess your work, but could you send me a link to a live example so it is easier for me to assess? You should be able to turn this GitHub repo into a live example using the GitHub pages functionality; see our handy guide for help on this: https://developer.mozilla.org/en-US/docs/Learn/Common_questions/Using_Github_pages
Hi,chrisdavidmills!
It was difficult. But I did it.
May you assess my work by link https://vovan1608.github.io/my-repository?
@zenya you did it — well done! Setting up github pages can be tricky to begin with, but it is really useful for publishing your own sites cheaply.
I’ve looked at your work, and I must say it is really good. Everything seems to work fine. The only thing I noticed is that the navigation menu buttons look no different when you hover over them, because the :hover color is the same. I think this is because they are using the same styles as the regular links.
So for the nav meny items, you might want to style them separately using a more specific selector (e.g. nav a { }
, nav a:hover { }
), and then give them separate styles.
Also, to make the hit area on the nav button the whole size of the button, and not just the text, size the <a>
element rather than the <li>
element. You might have to give the <a>
element a different display model, like flex, or at least inline-block, to make it accept sizing information.
Thanks for feedback. I’ve understood.
Hei, chrisdavidmills!
May you assess my works by links
https://vovan1608.github.io/Box-model-skill-test-1/
https://vovan1608.github.io/my-repository/
Thanks in advance!
Hey there @zenya!
The updated “Typesetting a community school homepage” assessment looks great — the nav buttons look perfect now!
As for the box model exercise, you got all of these correct. The only issue I saw is that you’ve misspelt margin
as margine
, so the margins are not applying in the 2nd exercise.
One tip about this as well — if you have four separate margins to apply to the four sides of a box, you can do it a single line, of this form:
margin: top-value right-value bottom-value left-value
Try experimenting with this too!
I’m grateful to you!