Hello everyone! Please check my homework

Typesetting a community school homepage

Hello everyone! Please check my homework.
My Github

Thank you and have a nice day! :smiley:

Hi @sjmcsy

It’s cool that you have uploaded your code to GitHub. Could you please activate GitHub Pages for your project? Then you can paste the link here and we are able to see the working code.
https://docs.github.com/en/pages/getting-started-with-github-pages/configuring-a-publishing-source-for-your-github-pages-site

This is especially useful in this layout-heavy exercise.
Thank you very much! :blush:

Cheers,
Michael

2 Likes

Thank you so much, Michael!
I never know that before, I will give it a try later and have a nice day!

Jimmy,
Shen

2 Likes

Hello @mikoMK! I did it. Thank you so much! :rofl:

Typesetting a community school homepage

Home work at GitHub

Hi @sjmcsy

I finally had time to look at your exercise. I had some busy days and apologize for the delay. :sweat_smile:

From a technically point of view everything is correctly solved. Congratulations! :medal_sports:
I have a few comments regarding certain styles you’ve chosen. These are just some points to think about:

  • Increasing the font on :active makes the text after it shift. Maybe a better solution is to use a background color or another text color.
  • The color of visited and unvisited links are the same. Maybe change the color to let the user see where they already were.
  • When navigating with a keyboard through the nav items you don’t know on which item you are (:focus state). See advice from first point :arrow_up:

I hope my comments help you. :slightly_smiling_face:

Have a nice weekend,
Michael

1 Like

Hi @mikoMK,

Thank you very much, I will keep learning more. Your comments are very importent to me.

Have a nice day,
Jimmy

2 Likes