Can you give me an Assessment for Marking up a letter?

MDN Learn
1

Thank yoou for your time! :+1: :+1: :smiley: :smiley:

2

Hi @das.serban

Very well done. :medal_sports:

I have only some small remarks:

  • The last <br> inside the <address>es can be omitted, because the end tag automatically breaks the line.
  • As you can see the date after the first address isn’t aligned to the right side. The reason is that <time> is an inline element and text-align: right; has therefore no effect. You should wrap <time> with <p> (which is a block element) and put the class on that.
  • The links are missing title attributes.
  • “Esq.” is the title of the person and should therefore also be inside <cite>.

As you can see only minor things. Everything else is perfect. :ok_hand:

I hope that helps,
Michael

4

Thank you so much for your feedback! :+1:

1 Like