JQuery 2 not allowed any more

hawk_lord · December 7, 2017, 5:13pm

JQuery 2 is not allowed since 2 May:

Why?

sylvaing · December 7, 2017, 5:21pm

Currently, only AngularJS 1.x (below 1.6.5) and jQuery 1.x are banned.

mozilla/addons-linter/blob/master/docs/third-party-libraries.md

# About 3rd Party Libraries in Add-ons

We maintain a list of banned and unadvised third-party JavaScript libraries; these libraries are not allowed/recommended in add-ons (because of security vulnerabilities).

## Banned libraries

### AngularJS `1.x`

AngularJS `1.x` versions below `1.6.5` are not allowed due to a [CSP vulnerability](http://www.slideshare.net/x00mario/an-abusive-relationship-with-angularjs).

We allow the latest 1.x version at submission time; all previous versions are banned.

### jQuery `1.x`

jQuery versions older than 2.0 are not supported by the jQuery team for development inside extensions. Please use a recent version.

hawk_lord · December 7, 2017, 5:34pm

JQuery 2 was deleted from the allowed list, and my add-on was disabled today because of that.

github.com

mozilla/amo-validator/blob/master/validator/testcases/hashes-allowed.txt

3ca7274302353b8386c230cfed846b122a97fe60a611ff73e88a657d56cc3a3b angularjs.1.6.6.angular.js
35f73a70cca067828be9e0a712b8b48908e1bc4490637c62bd70158f95cd6e27 angularjs.1.6.6.angular.min.js
918b67113f134ec866265fb26365dc1497c88af997f75bbd70ef8450ca7658e6 backbone.1.0.0.backbone-min.js
2ebbacdc8393dac4ce1d4cfbb8eb1957ba7bd7811fa7bed67c94a4a1193a78f3 backbone.1.0.0.backbone.js
453ec40e1cf3ecc3309a6a5bbf0ae555ee2f5f80075e48e86ce37dc247dc135c backbone.1.1.0.backbone-min.js
5a36cd2b29bc952610f3d8689348056a9a0658014552d77eb47b23bc0f3350a8 backbone.1.1.0.backbone.js
06fac5a66f26137240f94bef2fc0d15f75fa2effe8aec8929b04eb60e6017436 backbone.1.1.1.backbone-min.js
f5f741e7991113473236eb4da601cd50b44bdaea52f3b792a481c588bcd901a4 backbone.1.1.1.backbone.js
75d28344b1b83b5fb153fc5939bdc10b404a754d93f78f7c1c8a8b81de376825 backbone.1.1.2.backbone-min.js
0977290d5e68ce40d516cd4dc3965586680024e51399f0ee54ee8ed3a99b1506 backbone.1.1.2.backbone.js
e2880d9b382972780cbd99f9873c4fdf06618b36a8a3666bdb9d895845816f40 backbone.1.2.0.backbone-min.js
4ac1c9ebee6ebcd1614a8f92d41cb270e61e0b8f61c804c0d1b26fda4b889824 backbone.1.2.0.backbone.js
a593ba9f6e85ce030c59fd367c88b624d267b2a8d895fc7b3dcec52cc5137084 backbone.1.2.1.backbone-min.js
c27c8ad6ec8e148ed22a32035d67582e6affcdfa234e2cb2fac6611dbfd1781a backbone.1.2.1.backbone.js
a7a6e47c5aa6c6d79baca392fb0c868be41fdddd75d5e59440febb91ec9727a4 backbone.1.2.2.backbone-min.js
0b505a72e89152018c40056b6dd713668f96dbf508c0930e6ce7302cb7acfd88 backbone.1.2.2.backbone.js
c3ca23012efd03572816f91fb7addce549b1c9a327703f47735d153db22365fe backbone.1.2.3.backbone-min.js
3dd6732dfa24d1d79279ab81672b2092604b543489af42c7eba281f990c0cc43 backbone.1.2.3.backbone.js
1d9d21d7b55593465f76af4bd0572f414cec6f1e9acbe0a3e1780361b8243daf backbone.1.3.1.backbone-min.js
b432f5da40a1a53b029f51a42aa99ac21bc602d9af942836f8c7b70d3d74da74 backbone.1.3.1.backbone.js

This file has been truncated. show original

sylvaing · December 7, 2017, 5:39pm

Can you please provide the url of your add-on on AMO ? I’ll take a look at it.

hawk_lord · December 7, 2017, 5:46pm

Thanks.
https://addons.mozilla.org/en-US/developers/addon/direct-currency-converter-for-/versions

sylvaing · December 7, 2017, 5:55pm

I’ve added some notes to your reviewer regarding the usage of jQuery 2.x. Please disregard the issue. You should however submit a new build with fixes regarding the other issue that was provided in the review.

Let me know if there is any other problems.

You can also contact me directly on IRC : Channel #addon-reviewers on server irc.mozilla.org : https://wiki.mozilla.org/IRC . My nickname there is “spoji”.

Thank you for your understanding!