My jquery file was rejected by a reviewer and no clue or hint given - weird


(Swifter Code) #1

Hello guys,
My add-on was rejected by a reviewer and the reason mentioned by him was that your version of jquery was modified.
After screwing my head for few hours, I got the result below. Please help

Rejected by erosman a day ago

This add-on didn’t pass review because of the following problems: 1) Your add-on includes a JavaScript library file that doesn’t match any versions known to us. We require all add-ons to use unmodified release versions. e.g.: js/jquery.js

Developer Reply by [Mustafa Hussain] about 24 hours ago

Hello erosman, I am sure that the jquery.js is unmodified version of jquery downloaded from jquery website here is the link https://code.jquery.com/jquery-3.3.1.min.js. my chrome version is also using. I have renamed the file name and renaming file name doesn’t mean it has been modified. Please enable my extension as soon as possible and immediately. Regards, Mustafa H.

Reviewer Reply by [erosman] about 23 hours ago

Hello Renaming the file does not matter. Original jQuery v3.3.1 min SHA256 hash: f971b901aeb9e55b07d472afee09bd5ae05159e1119dbd16d993e473565e7fc0 addon’s jQuery v3.3.1 min SHA256 hash: a28ccf8a7b50522bdeea0cd83cdeca221c18fc1f9df3ee6b3d3c48d599206855

Developer Reply by [Mustafa Hussain] about 23 hours ago

Please send me the link for your version of jquery. I am using this https://code.jquery.com/jquery-3.3.1.min.js and its sha256 is a28ccf8a7b50522bdeea0cd83cdeca221c18fc1f9df3ee6b3d3c48d599206855 I simply copy and paste it here https://passwordsgenerator.net/sha256-hash-generator/ please also review your copy of jquery Regards, Mustafa H.

Reviewer Reply by [erosman] about 22 hours ago

Hello Sorry I wrote the wrong hash in my previous message for Original jQuery v3.3.1 min SHA256 The following is the correct hash which doesn’t match addons: https://code.jquery.com/jquery-3.3.1.min.js SHA256 hash: 160a426ff2894252cd7cebbdd6d6b7da8fcd319c65b70468f10b6690c45d02ef

Developer Reply by [Mustafa Hussain] about 19 hours ago

hi, I have used the same version of jquery and its has is coming different from yours. Please review. Regards, Mustafa H.

Reviewer Reply by [erosman] about 11 hours ago

Hello If you wish to discuss the issues further, you can reach admin reviewers on IRC #addon-reviewers on irc://mozilla.org/

Developer Reply by [Mustafa Hussain] about an hour ago

Hello man, Why don’t you send me the unmodified file ???


(Jorge) #2

You need to download the library file from the original source (jquery.com) and be careful to not modify it. Sometimes just opening it in an IDE and saving it without any content change can change its encoding and break the hash.

Can you try downloading the file and checking the hash, to see if it matches what the reviewer pointed out?


(Swifter Code) #3

Hey Jorgev,
Thanks for your response. I did what you suggested and it worked for me. I was copy pasting and there was an empty line at the end of file which was trimmed. Now I am getting accurate hash.
Thanks for the help
Regards,
Mustafa H.